Adjust build to make plugin for testing #3366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Apr 11, 2019
| "ideaVersion": "2019.1", | ||
| "dartPluginVersion": "191.4899", | ||
| "sinceBuild": "192.0", | ||
| "sinceBuild": "191.0", |
There was a problem hiding this comment.
I think we'll over overlap issue wrt the version ranges that match each plugin (2019.1 vs 2019.2). Is this something we'd want to land? Something to enable testing?
|
I see your point. If this build was published it would collide with the
released version for 2019.1. But this one doesn't get published since the
EAP for 2019.2 isn't out yet. When the EAP is out this spec will be updated
to work with it. Meanwhile we need a 192.* version to work with the
debugger, and it also can be used with the integration tests. A bit hacky,
but only for internal use.
…On Wed, Apr 10, 2019, 7:39 PM Devon Carew ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm, if you think the change is something that we want to land
------------------------------
In product-matrix.json
<#3366 (comment)>
:
> "ideaProduct": "ideaIU",
"ideaVersion": "2019.1",
"dartPluginVersion": "191.4899",
- "sinceBuild": "192.0",
+ "sinceBuild": "191.0",
I think we'll over overlap issue wrt the version ranges that match each
plugin (2019.1 vs 2019.2). Is this something we'd want to land? Something
to enable testing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3366 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIH6jV15v9acyBClKSltv3gqHdaPVzitks5vfqBpgaJpZM4coR-d>
.
|
|
Landing sounds good, but we'll just need to be careful to make the supported versions above disjoint before we next publish. Related but separate from this PR, it would be nice to have some validation on the bots that our version ranges don't overlap. |
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust build to produce a plugin suitable for integration testing.